8385746: S390: Improve receiver type profiling reliability - #31510
offamitkumar wants to merge 2 commits into
Conversation
|
👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into |
|
@offamitkumar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
openjdk
Bot
changed the title
|
@offamitkumar The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Webrevs
|
shipilev
left a comment
shipilev
left a comment
There was a problem hiding this comment.
Looks like a reasonable port of the original change.
|
@TheRealMDoerr can you take a look at this, as it is derived from ppc changes. |
TheRealMDoerr
left a comment
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Note that s390 also has instructions for counted loops which would probably generate shorter code. Nevertheless, looks correct.
|
Thanks for the reviews. /integrate |
|
@offamitkumar This pull request has not yet been marked as ready for integration. |
|
/integrate |
|
Going to push as commit 8de834c.
Your commit was automatically rebased without conflicts. |
openjdk
Bot
removed
ready
|
@offamitkumar Pushed as commit 8de834c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
3 participants
s390 port, other architectures have already been ported.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31510/head:pull/31510$ git checkout pull/31510Update a local copy of the PR:
$ git checkout pull/31510$ git pull https://git.openjdk.org/jdk.git pull/31510/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31510View PR using the GUI difftool:
$ git pr show -t 31510Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31510.diff
Using Webrev
Link to Webrev Comment